ferrous_sapling/activity-pub-explorer
1
0
Fork 0
Code Issues 6 Pull requests Projects 1 Releases Packages Wiki Activity Actions

Editing a Feed #4

Closed
ferrous_sapling wants to merge 0 commits from editing-a-feed into main
pull from: editing-a-feed
merge into: ferrous_sapling:main
Conversation 2 Commits - Files changed -
ferrous_sapling commented 2025-07-21 11:11:17 +00:00
Owner
Copy link

Changelist:

  • feeds now have names (default is url.hostname + url.pathname)
  • new page at route /feeds/[feedUrl]:
    • view and edit feed attributes (url, name, type)
    • button to delete the feed from the app (requires 2 clicks to prevent accidental deletion)
    • can also be accessed at route /feeds/[feedId] (useful for programmatic navigation, notably when a user edits the url for a feed)
  • new buttons/links in the "viewed feeds" form to navigate to each feed's "details" page
  • new features on diagnostics page:
    • view all of the current known feed types
    • view all of the current known feeds
Changelist: - feeds now have names (default is `url.hostname + url.pathname`) - new page at route `/feeds/[feedUrl]`: - view and edit feed attributes (url, name, type) - button to delete the feed from the app (requires 2 clicks to prevent accidental deletion) - can also be accessed at route `/feeds/[feedId]` (useful for programmatic navigation, notably when a user edits the url for a feed) - new buttons/links in the "viewed feeds" form to navigate to each feed's "details" page - new features on diagnostics page: - view all of the current known feed types - view all of the current known feeds
rename /explorer route to /feeds

add edit button/link to each feed in feeds form
define index names in service config

add id_, name fields on DBFeed
switch DBFeed's primary key to id_, enable autoIncrement for it

change service.removeFeed() to use a cursor on the url index: the url is no longer the primary key, so we can't directly call store.delete() with it

move form for adding a new feed to the feeds view/page

enable the feeds/[feedUrl] page to actually persist the changes the user makes
allow user to preview a feed's most recent objects on that feed's page
using a redirect to /feeds/[feedUrl]
generate default name as url.hostname + url.pathname
generate default name as url.hostname + url.pathname
ferrous_sapling commented 2025-07-24 11:56:39 +00:00
Author
Owner
Copy link

From a user's point of view this is incomplete: even if they can edit a feed's type they can only change it to existing types, and there is only ever the "unknown" type available.
Nevertheless, adding a new feed type is outside the scope of this PR (and of the original issue #2) so it will remain unaddressed in this PR.

From a user's point of view this is incomplete: even if they can edit a feed's type they can only change it to existing types, and there is only ever the `"unknown"` type available. Nevertheless, adding a new feed _type_ is outside the scope of this PR (and of the original issue #2) so it will remain unaddressed in this PR.
ferrous_sapling commented 2025-07-30 08:46:31 +00:00
Author
Owner
Copy link

merged in 7e269bc720

merged in 7e269bc720
ferrous_sapling closed this pull request 2025-07-30 08:46:31 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ferrous_sapling/activity-pub-explorer!4
No description provided.